phillip/ingress-intel-total-conversion
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Plugin AP List: Fix some minor bugs and add comments

Browse Source
This commit is contained in:
Xelio 2013-03-26 03:39:54 +08:00
parent 8f9049fdf3
commit 26cd8b2a8d
1 changed files with 21 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
plugins/ap-list.user.js
View File

@ -374,22 +374,16 @@ window.plugin.apList.getDeployOrUpgradeApGain = function(d) {
// by others(only level lower than player level) or by player. // by others(only level lower than player level) or by player.
for(var i = 0; i < 8; i++) { for(var i = 0; i < 8; i++) {
var reso = d.resonatorArray.resonators[i]; var reso = d.resonatorArray.resonators[i];
// Empty reso
if(!reso) { if(!reso) {
// Empty reso otherReso.push({slot: i, level: 0});
reso = {slot: i, level: 0};
otherReso.push(reso);
continue; continue;
} }
// By player // By player
if(reso.ownerGuid === window.PLAYER.guid) { if(reso.ownerGuid === window.PLAYER.guid) {
if(!playerResoCount[reso.level]) playerResoCount[reso.level] = (playerResoCount[reso.level] || 0) + 1;
playerResoCount[reso.level] = 0;
playerResoCount[reso.level]++;
continue; continue;
} }
// By others and level lower than player // By others and level lower than player
if(reso.level < window.PLAYER.level) { if(reso.level < window.PLAYER.level) {
otherReso.push(reso); otherReso.push(reso);
@ -541,6 +535,13 @@ window.plugin.apList.getShieldsMitigation = function(portal) {
} }
// For using in .sort(func) of sortedPortals // For using in .sort(func) of sortedPortals
// Use options in plugin.apList.sortOptions. Each type of sortBy has
// array of options. Option consist of an ordering and a property chain.
//
// Sorting done by loop through the options, get the property by
// property chain of each option, compare the property of two object
// with the ordering of option and return the result when the first
// differece is found.
window.plugin.apList.comparePortal = function(a,b) { window.plugin.apList.comparePortal = function(a,b) {
var result = 0; var result = 0;
var options = plugin.apList.sortOptions[plugin.apList.sortBy]; var options = plugin.apList.sortOptions[plugin.apList.sortBy];
@ -579,7 +580,15 @@ window.plugin.apList.disableCache = function() {
} }
window.plugin.apList.selectPortal = function(guid) { window.plugin.apList.selectPortal = function(guid) {
renderPortalDetails(guid); // Add error catching to avoid following link of portal if error
// occured in renderPortalDetails or hooked plugin
try {
renderPortalDetails(guid);
} catch(e) {
console.error(e.message);
console.log(e.stack);
console.log('Skipping error in renderPortalDetails or hooked plugin')
}
plugin.apList.setPortalLocationIndicator(guid); plugin.apList.setPortalLocationIndicator(guid);
} }
@ -720,6 +729,8 @@ window.plugin.apList.setupVar = function() {
= "#ap-list-frd"; = "#ap-list-frd";
plugin.apList.sideLabelClass[plugin.apList.SIDE_ENEMY] plugin.apList.sideLabelClass[plugin.apList.SIDE_ENEMY]
= "#ap-list-eny"; = "#ap-list-eny";
plugin.apList.sortedPortals[plugin.apList.SIDE_FRIENDLY] = new Array();
plugin.apList.sortedPortals[plugin.apList.SIDE_ENEMY] = new Array();
} }
window.plugin.apList.setupSorting = function() { window.plugin.apList.setupSorting = function() {