From 375a32e8bdb833590917595a95c8b55fbe8048e7 Mon Sep 17 00:00:00 2001 From: Jon Atkins Date: Thu, 29 Aug 2013 20:47:56 +0100 Subject: [PATCH] fix infrastructure highlighter to work with changes to portal data for #514 --- .../portal-highlighter-infrastructure.user.js | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/plugins/portal-highlighter-infrastructure.user.js b/plugins/portal-highlighter-infrastructure.user.js index 222ee0b8..2b102244 100644 --- a/plugins/portal-highlighter-infrastructure.user.js +++ b/plugins/portal-highlighter-infrastructure.user.js @@ -2,11 +2,11 @@ // @id iitc-plugin-highlight-portal-infrastructure@vita10gy // @name IITC plugin: highlight portals with infrastructure problems // @category Highlighter -// @version 0.1.0.@@DATETIMEVERSION@@ +// @version 0.2.0.@@DATETIMEVERSION@@ // @namespace https://github.com/jonatkins/ingress-intel-total-conversion // @updateURL @@UPDATEURL@@ // @downloadURL @@DOWNLOADURL@@ -// @description [@@BUILDNAME@@-@@BUILDDATE@@] Red - No Picture, Orange - More than one picture (probably means the original was bad, upvote new), Yellow - Potential title issue +// @description [@@BUILDNAME@@-@@BUILDDATE@@] Red - No Picture, Yellow - Potential title issue, Orange - both of these // @include https://www.ingress.com/intel* // @include http://www.ingress.com/intel* // @match https://www.ingress.com/intel* @@ -32,22 +32,19 @@ window.plugin.portalInfrastructure.highlight = function(data) { var d = data.portal.options.details; var color = ''; var opa = .75; - - if(d.photoStreamInfo.photoCount === 0) { + + if(!(d.imageByUrl && d.imageByUrl.imageUrl)) { color = 'red'; } - else if(d.photoStreamInfo.photoCount > 1) { - color = 'orange'; - } - else if((new RegExp(window.plugin.portalInfrastructure.badTitles.join("|"),'i')).test(d.portalV2.descriptiveText.TITLE)) { - color = 'yellow'; + + if((new RegExp(window.plugin.portalInfrastructure.badTitles.join("|"),'i')).test(d.portalV2.descriptiveText.TITLE)) { + color = color == 'red' ? 'orange' : 'yellow'; opa = .9; } if(color !== '') { var params = {fillColor: color, fillOpacity: opa}; data.portal.setStyle(params); - window.COLOR_SELECTED_PORTAL = '#f0f'; } }