From 6b7525836dfd60f5c17cc54d02c5dfef590a0bef Mon Sep 17 00:00:00 2001 From: fkloft Date: Sun, 26 Jan 2014 14:29:44 +0100 Subject: [PATCH] add final modifiers to IITC_JSInterface --- .../cradle/iitc_mobile/IITC_JSInterface.java | 43 +++++++++---------- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/mobile/src/com/cradle/iitc_mobile/IITC_JSInterface.java b/mobile/src/com/cradle/iitc_mobile/IITC_JSInterface.java index 78080700..4b22d0a8 100644 --- a/mobile/src/com/cradle/iitc_mobile/IITC_JSInterface.java +++ b/mobile/src/com/cradle/iitc_mobile/IITC_JSInterface.java @@ -17,14 +17,15 @@ public class IITC_JSInterface { // context of main activity private final IITC_Mobile mIitc; - IITC_JSInterface(IITC_Mobile iitc) { + IITC_JSInterface(final IITC_Mobile iitc) { mIitc = iitc; } // open dialog to send geo intent for navigation apps like gmaps or waze etc... @JavascriptInterface - public void intentPosLink(double lat, double lng, int zoom, String title, boolean isPortal) { - Intent intent = new Intent(mIitc, ShareActivity.class); + public void intentPosLink( + final double lat, final double lng, final int zoom, final String title, final boolean isPortal) { + final Intent intent = new Intent(mIitc, ShareActivity.class); intent.putExtra("lat", lat); intent.putExtra("lng", lng); intent.putExtra("zoom", zoom); @@ -35,8 +36,8 @@ public class IITC_JSInterface { // share a string to the IITC share activity. only uses the share tab. @JavascriptInterface - public void shareString(String str) { - Intent intent = new Intent(mIitc, ShareActivity.class); + public void shareString(final String str) { + final Intent intent = new Intent(mIitc, ShareActivity.class); intent.putExtra("shareString", str); intent.putExtra("onlyShare", true); mIitc.startActivity(intent); @@ -45,16 +46,15 @@ public class IITC_JSInterface { // disable javascript injection while spinner is enabled // prevent the spinner from closing automatically @JavascriptInterface - public void spinnerEnabled(boolean en) { + public void spinnerEnabled(final boolean en) { mIitc.getWebView().disableJS(en); } // copy link to specific portal to android clipboard @JavascriptInterface - public void copy(String s) { - ClipboardManager clipboard = (ClipboardManager) mIitc - .getSystemService(Context.CLIPBOARD_SERVICE); - ClipData clip = ClipData.newPlainText("Copied Text ", s); + public void copy(final String s) { + final ClipboardManager clipboard = (ClipboardManager) mIitc.getSystemService(Context.CLIPBOARD_SERVICE); + final ClipData clip = ClipData.newPlainText("Copied Text ", s); clipboard.setPrimaryClip(clip); Toast.makeText(mIitc, "copied to clipboard", Toast.LENGTH_SHORT).show(); } @@ -63,10 +63,9 @@ public class IITC_JSInterface { public int getVersionCode() { int versionCode = 0; try { - PackageInfo pInfo = mIitc.getPackageManager() - .getPackageInfo(mIitc.getPackageName(), 0); + final PackageInfo pInfo = mIitc.getPackageManager().getPackageInfo(mIitc.getPackageName(), 0); versionCode = pInfo.versionCode; - } catch (PackageManager.NameNotFoundException e) { + } catch (final PackageManager.NameNotFoundException e) { Log.w(e); } return versionCode; @@ -75,11 +74,11 @@ public class IITC_JSInterface { @JavascriptInterface public String getVersionName() { String buildVersion = "unknown"; - PackageManager pm = mIitc.getPackageManager(); + final PackageManager pm = mIitc.getPackageManager(); try { - PackageInfo info = pm.getPackageInfo(mIitc.getPackageName(), 0); + final PackageInfo info = pm.getPackageInfo(mIitc.getPackageName(), 0); buildVersion = info.versionName; - } catch (PackageManager.NameNotFoundException e) { + } catch (final PackageManager.NameNotFoundException e) { Log.w(e); } return buildVersion; @@ -93,7 +92,7 @@ public class IITC_JSInterface { Pane pane; try { pane = mIitc.getNavigationHelper().getPane(id); - } catch (IllegalArgumentException e) { + } catch (final IllegalArgumentException e) { pane = Pane.MAP; } @@ -103,12 +102,12 @@ public class IITC_JSInterface { } @JavascriptInterface - public void dialogFocused(String id) { + public void dialogFocused(final String id) { mIitc.setFocusedDialog(id); } @JavascriptInterface - public void dialogOpened(String id, boolean open) { + public void dialogOpened(final String id, final boolean open) { mIitc.dialogOpened(id, open); } @@ -190,9 +189,9 @@ public class IITC_JSInterface { @JavascriptInterface public boolean showZoom() { - PackageManager pm = mIitc.getPackageManager(); - boolean hasMultitouch = pm.hasSystemFeature(PackageManager.FEATURE_TOUCHSCREEN_MULTITOUCH); - boolean forcedZoom = mIitc.getPrefs().getBoolean("pref_user_zoom", false); + final PackageManager pm = mIitc.getPackageManager(); + final boolean hasMultitouch = pm.hasSystemFeature(PackageManager.FEATURE_TOUCHSCREEN_MULTITOUCH); + final boolean forcedZoom = mIitc.getPrefs().getBoolean("pref_user_zoom", false); return forcedZoom || !hasMultitouch; }