phillip/ingress-intel-total-conversion
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

likely fix #173

Browse Source 
If I understood everything correctly, the reason was that the for-loop
doesn’t create a separate context, thus the reference to r was made for
the whole renderResonator function. This obviously references the latest
r after the loop has finished. Switching this to $.each where each
iteration is a new anonymous function and thus a closure, r is referenced
correctly.

Please reopen if this does not fix the problem.
This commit is contained in:
Stefan Breunig 2013-02-15 16:04:10 +01:00
parent 4d6e0b5ebb
commit 6de035b0ab
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
code/map_data.js
View File

@ -308,19 +308,17 @@ window.renderResonators = function(ent, portalLayer) {
var layerGroup = portalsLayers[parseInt(portalLevel)]; var layerGroup = portalsLayers[parseInt(portalLevel)];
var reRendered = false; var reRendered = false;
for(var i = 0; i < ent[2].resonatorArray.resonators.length; i++) { $.each(ent[2].resonatorArray.resonators, function(i, rdata) {
var rdata = ent[2].resonatorArray.resonators[i];
// skip if resonator didn't change // skip if resonator didn't change
if(portalLayer) { if(portalLayer) {
var oldRes = findEntityInLeaflet(layerGroup, window.resonators, portalResonatorGuid(ent[0], i)); var oldRes = findEntityInLeaflet(layerGroup, window.resonators, portalResonatorGuid(ent[0], i));
if(oldRes && isSameResonator(oldRes.options.details, rdata)) continue; if(oldRes && isSameResonator(oldRes.options.details, rdata)) return true;
} }
// skip and remove old resonator if no new resonator // skip and remove old resonator if no new resonator
if(rdata === null) { if(rdata === null) {
if(oldRes) removeByGuid(oldRes.options.guid); if(oldRes) removeByGuid(oldRes.options.guid);
continue; return true;
} }
// offset in meters // offset in meters
@ -379,7 +377,7 @@ window.renderResonators = function(ent, portalLayer) {
r.addTo(portalsLayers[parseInt(portalLevel)]); r.addTo(portalsLayers[parseInt(portalLevel)]);
reRendered = true; reRendered = true;
} });
// if there is any resonator re-rendered, bring portal to front // if there is any resonator re-rendered, bring portal to front
if(reRendered && portalLayer) portalLayer.bringToFront(); if(reRendered && portalLayer) portalLayer.bringToFront();
} }