From 341b3d4a7d1191c0c99079c803569c83cf6a0eee Mon Sep 17 00:00:00 2001 From: boombuler Date: Wed, 27 Feb 2013 13:04:30 +0100 Subject: [PATCH 1/5] add "nickname" class to all nicknames within the page --- code/chat.js | 2 +- code/portal_detail_display.js | 1 + code/portal_detail_display_tools.js | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/code/chat.js b/code/chat.js index 6faea140..153c5105 100644 --- a/code/chat.js +++ b/code/chat.js @@ -347,7 +347,7 @@ window.chat.renderMsg = function(msg, nick, time, team) { var s = 'style="color:'+COLORS[team]+'"'; var title = nick.length >= 8 ? 'title="'+nick+'" class="help"' : ''; var i = ['<', '>']; - return ''+t+''+i[0]+''+nick+''+i[1]+''+msg+''; + return ''+t+''+i[0]+''+nick+''+i[1]+''+msg+''; } diff --git a/code/portal_detail_display.js b/code/portal_detail_display.js index c3be0a8a..d9855ba4 100644 --- a/code/portal_detail_display.js +++ b/code/portal_detail_display.js @@ -24,6 +24,7 @@ window.renderPortalDetails = function(guid) { var player = d.captured && d.captured.capturingPlayerId ? getPlayerName(d.captured.capturingPlayerId) : null; + player = ''+player+''; var playerText = player ? ['owner', player] : null; var time = d.captured diff --git a/code/portal_detail_display_tools.js b/code/portal_detail_display_tools.js index 2861edf7..9a50e1b7 100644 --- a/code/portal_detail_display_tools.js +++ b/code/portal_detail_display_tools.js @@ -132,6 +132,7 @@ window.renderResonatorDetails = function(slot, level, nrg, dist, nick) { var meter = '' + fill + lbar + ''; } + nick = ''+nick+''; return [meter, nick || '']; } From 5fba0a4179a3c32bdc990fcbb77de684e69534ac Mon Sep 17 00:00:00 2001 From: boombuler Date: Wed, 27 Feb 2013 13:05:20 +0100 Subject: [PATCH 2/5] add the playerlevel to all "nickname"-classed elements --- plugins/guess-player-levels.user.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/plugins/guess-player-levels.user.js b/plugins/guess-player-levels.user.js index c220a76d..0c7259ef 100644 --- a/plugins/guess-player-levels.user.js +++ b/plugins/guess-player-levels.user.js @@ -51,11 +51,7 @@ window.plugin.guessPlayerLevels.setLevelTitle = function(dom) { } window.plugin.guessPlayerLevels.setupChatNickHelper = function() { - $('#portaldetails').delegate('#resodetails .meter-text', 'mouseenter', function() { - window.plugin.guessPlayerLevels.setLevelTitle(this); - }); - - $('#chat').delegate('mark', 'mouseenter', function() { + $(window).delegate('.nickname', 'mouseenter', function() { window.plugin.guessPlayerLevels.setLevelTitle(this); }); } From 3f76d6c7a68497e523c076a8e5caaae0f775fd5d Mon Sep 17 00:00:00 2001 From: boombuler Date: Wed, 27 Feb 2013 15:47:16 +0100 Subject: [PATCH 3/5] prevent browser tooltip --- plugins/guess-player-levels.user.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/guess-player-levels.user.js b/plugins/guess-player-levels.user.js index 0c7259ef..b04e67a3 100644 --- a/plugins/guess-player-levels.user.js +++ b/plugins/guess-player-levels.user.js @@ -47,7 +47,8 @@ window.plugin.guessPlayerLevels.setLevelTitle = function(dom) { } else { text = 'Min player level unknown'; } - el.attr('title', text).addClass('help'); + window.setupTooltips(el); + el.addClass('help').attr('title', text).tooltip('open').attr('title', null); } window.plugin.guessPlayerLevels.setupChatNickHelper = function() { From 59371e09a31ba42f6e0235effd083fd41adc3f78 Mon Sep 17 00:00:00 2001 From: boombuler Date: Fri, 1 Mar 2013 22:08:22 +0100 Subject: [PATCH 4/5] added some comments --- plugins/guess-player-levels.user.js | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/plugins/guess-player-levels.user.js b/plugins/guess-player-levels.user.js index b04e67a3..829f1e2d 100644 --- a/plugins/guess-player-levels.user.js +++ b/plugins/guess-player-levels.user.js @@ -48,7 +48,17 @@ window.plugin.guessPlayerLevels.setLevelTitle = function(dom) { text = 'Min player level unknown'; } window.setupTooltips(el); - el.addClass('help').attr('title', text).tooltip('open').attr('title', null); + + /* + This code looks hacky but since we are a little late within the mouseenter so + we need to improvise a little. The open method doesn't open the tooltip directly. + It starts the whole opening procedure (including the timeout etc) and is normally + started by the mousemove event of the enhanced element. + */ + el.addClass('help') // Add the "Help Mouse Cursor" + .attr('title', text) // Set the title for the jquery tooltip + .tooltip('open') // Start the "open" method + .attr('title', null); // And remove the title to prevent the browsers tooltip } window.plugin.guessPlayerLevels.setupChatNickHelper = function() { From 087964847e534aebca14096acb2c8f9cc7112816 Mon Sep 17 00:00:00 2001 From: boombuler Date: Fri, 1 Mar 2013 22:12:04 +0100 Subject: [PATCH 5/5] moved nickname css class commit to different branch. This reverts commit 341b3d4a7d1191c0c99079c803569c83cf6a0eee. --- code/chat.js | 2 +- code/portal_detail_display.js | 1 - code/portal_detail_display_tools.js | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/code/chat.js b/code/chat.js index 153c5105..6faea140 100644 --- a/code/chat.js +++ b/code/chat.js @@ -347,7 +347,7 @@ window.chat.renderMsg = function(msg, nick, time, team) { var s = 'style="color:'+COLORS[team]+'"'; var title = nick.length >= 8 ? 'title="'+nick+'" class="help"' : ''; var i = ['<', '>']; - return ''+t+''+i[0]+''+nick+''+i[1]+''+msg+''; + return ''+t+''+i[0]+''+nick+''+i[1]+''+msg+''; } diff --git a/code/portal_detail_display.js b/code/portal_detail_display.js index d9855ba4..c3be0a8a 100644 --- a/code/portal_detail_display.js +++ b/code/portal_detail_display.js @@ -24,7 +24,6 @@ window.renderPortalDetails = function(guid) { var player = d.captured && d.captured.capturingPlayerId ? getPlayerName(d.captured.capturingPlayerId) : null; - player = ''+player+''; var playerText = player ? ['owner', player] : null; var time = d.captured diff --git a/code/portal_detail_display_tools.js b/code/portal_detail_display_tools.js index 9a50e1b7..2861edf7 100644 --- a/code/portal_detail_display_tools.js +++ b/code/portal_detail_display_tools.js @@ -132,7 +132,6 @@ window.renderResonatorDetails = function(slot, level, nrg, dist, nick) { var meter = '' + fill + lbar + ''; } - nick = ''+nick+''; return [meter, nick || '']; }