phillip/ingress-intel-total-conversion
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

remove all signs of portal photo submitter info when there's no photo submitter information supplied

Browse Source 
for #514
This commit is contained in:
Jon Atkins 2013-08-29 01:10:44 +01:00
parent d1ce8870ba
commit 90047abee0
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
code/portal_detail_display.js
View File

@ -67,7 +67,7 @@ window.renderPortalDetails = function(guid) {
submitterSpan = '<span class="none">'; submitterSpan = '<span class="none">';
} }
portalDetailedDescription += '<tr><th>Photo by:</th><td>' + submitterSpan portalDetailedDescription += '<tr><th>Photo by:</th><td>' + submitterSpan
+ escapeHtmlSpecialChars(portalDetailObj.submitter.name) + '</span> (' + portalDetailObj.submitter.voteCount + ' votes)</td></tr>'; + escapeHtmlSpecialChars(portalDetailObj.submitter.name) + '</span>'+(portalDetailObj.submitter.voteCount !== undefined ? ' (' + portalDetailObj.submitter.voteCount + ' votes)' : '')+'</td></tr>';
} }
if(portalDetailObj.submitter.link.length > 0) { if(portalDetailObj.submitter.link.length > 0) {
portalDetailedDescription += '<tr><th>Photo from:</th><td><a href="' portalDetailedDescription += '<tr><th>Photo from:</th><td><a href="'

6
code/portal_detail_display_tools.js
View File

@ -33,12 +33,14 @@ window.getPortalDescriptionFromDetailsExtended = function(details) {
var submitterObj = new Object(); var submitterObj = new Object();
submitterObj.type = ""; submitterObj.type = "";
submitterObj.name = "Unknown"; submitterObj.name = "";
submitterObj.team = ""; submitterObj.team = "";
submitterObj.link = ""; submitterObj.link = "";
submitterObj.voteCount = 0; submitterObj.voteCount = undefined;
if(photoStreamObj && photoStreamObj.hasOwnProperty("coverPhoto") && photoStreamObj.coverPhoto.hasOwnProperty("attributionMarkup")) { if(photoStreamObj && photoStreamObj.hasOwnProperty("coverPhoto") && photoStreamObj.coverPhoto.hasOwnProperty("attributionMarkup")) {
submitterObj.name = "Unknown";
var attribution = photoStreamObj.coverPhoto.attributionMarkup; var attribution = photoStreamObj.coverPhoto.attributionMarkup;
submitterObj.type = attribution[0]; submitterObj.type = attribution[0];
if(attribution[1].hasOwnProperty("plain")) if(attribution[1].hasOwnProperty("plain"))