From 9f9609f7e988c709bb8d31cf56725dc6fff807a8 Mon Sep 17 00:00:00 2001 From: Jon Atkins Date: Fri, 30 Jan 2015 00:26:51 +0000 Subject: [PATCH] improved error handling on portal details response handler --- code/portal_detail.js | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/code/portal_detail.js b/code/portal_detail.js index 3eb4f0e7..e68df525 100644 --- a/code/portal_detail.js +++ b/code/portal_detail.js @@ -50,6 +50,10 @@ var handleResponse = function(guid, data, success) { }; } + if (data.error || !data.result) { + success = false; + } + if (success) { var dict = { raw: data.result, @@ -75,9 +79,18 @@ var handleResponse = function(guid, data, success) { if (guid == selectedPortal) { renderPortalDetails(guid); } + + window.runHooks ('portalDetailLoaded', {guid:guid, success:success, details:dict}); + + } else { + if (data.error == "RETRY") { + // server asked us to try again + portalDetail.request(guid); + } else { + window.runHooks ('portalDetailLoaded', {guid:guid, success:success}); + } } - window.runHooks ('portalDetailLoaded', {guid:guid, success:success, details:dict}); } window.portalDetail.request = function(guid) {