phillip/ingress-intel-total-conversion
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Plugin AP List: add comments

Browse Source
This commit is contained in:
Xelio 2013-09-03 22:02:06 +08:00
parent 05cd054d50
commit cf985d872e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/ap-list.user.js
View File

@ -252,7 +252,7 @@ window.plugin.apList.updateSortedPortals = function() {
plugin.apList.sortedPortals[plugin.apList.SIDE_FRIENDLY] = new Array(); plugin.apList.sortedPortals[plugin.apList.SIDE_FRIENDLY] = new Array();
plugin.apList.sortedPortals[plugin.apList.SIDE_ENEMY] = new Array(); plugin.apList.sortedPortals[plugin.apList.SIDE_ENEMY] = new Array();
// Make a backup of cachedPortals // Make a backup of cachedPortals with shallow copy
// If cache is not enabled, empty cachedPortals. In following // If cache is not enabled, empty cachedPortals. In following
// "$.each" loop, the backup portal will copy back into // "$.each" loop, the backup portal will copy back into
// cachedPortals if it exist in "window.portals"" and didn't change.' // cachedPortals if it exist in "window.portals"" and didn't change.'
@ -269,7 +269,7 @@ window.plugin.apList.updateSortedPortals = function() {
// If portal is changed, update playerApGain with latest // If portal is changed, update playerApGain with latest
// information // information
if(!cachedPortal || value.timestamp !== cachedPortal.timestamp) { if(!cachedPortal || value.timestamp !== cachedPortal.timestamp) {
// Copy portal detail to cachedPortal // Shallow copy portal detail to cachedPortal
cachedPortal = $.extend({}, portal); cachedPortal = $.extend({}, portal);
var side = plugin.apList.portalSide(portal); var side = plugin.apList.portalSide(portal);
var getApGainFunc = plugin.apList.playerApGainFunc[side]; var getApGainFunc = plugin.apList.playerApGainFunc[side];
@ -353,7 +353,7 @@ window.plugin.apList.handleDestroyPortal = function() {
&& newLinkedFields.length === (portal.portalV2.linkedFields || []).length) && newLinkedFields.length === (portal.portalV2.linkedFields || []).length)
return true; return true;
// Clone the portal to avoid modifying original data in cachedPortal // Clone the portal with deep copy to avoid modifying original data in cachedPortal
var newPortal = $.extend(true, {}, portal); var newPortal = $.extend(true, {}, portal);
// Assign new links and fields and calculate new playerApGain // Assign new links and fields and calculate new playerApGain
if(portal.portalV2.linkedEdges) newPortal.portalV2.linkedEdges = newLinkedEdges; if(portal.portalV2.linkedEdges) newPortal.portalV2.linkedEdges = newLinkedEdges;