phillip/ingress-intel-total-conversion
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove warning, add final modifiers

Browse Source
This commit is contained in:
fkloft 2014-02-18 15:18:39 +01:00
parent 97acf64360
commit f9cf8d5518
1 changed files with 17 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
mobile/src/com/cradle/iitc_mobile/fragments/MainSettings.java
View File

@ -5,7 +5,6 @@ import android.content.pm.PackageInfo;
import android.content.pm.PackageManager; import android.content.pm.PackageManager;
import android.content.pm.PackageManager.NameNotFoundException; import android.content.pm.PackageManager.NameNotFoundException;
import android.os.Bundle; import android.os.Bundle;
import android.preference.EditTextPreference;
import android.preference.ListPreference; import android.preference.ListPreference;
import android.preference.Preference; import android.preference.Preference;
import android.preference.Preference.OnPreferenceChangeListener; import android.preference.Preference.OnPreferenceChangeListener;
@ -23,39 +22,39 @@ import com.cradle.iitc_mobile.R;
public class MainSettings extends PreferenceFragment { public class MainSettings extends PreferenceFragment {
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(final Bundle savedInstanceState) {
super.onCreate(savedInstanceState); super.onCreate(savedInstanceState);
addPreferencesFromResource(R.xml.preferences); addPreferencesFromResource(R.xml.preferences);
// set versions // set versions
String iitcVersion = getArguments().getString("iitc_version"); final String iitcVersion = getArguments().getString("iitc_version");
String buildVersion = "unknown"; String buildVersion = "unknown";
PackageManager pm = getActivity().getPackageManager(); final PackageManager pm = getActivity().getPackageManager();
try { try {
PackageInfo info = pm.getPackageInfo(getActivity().getPackageName(), 0); final PackageInfo info = pm.getPackageInfo(getActivity().getPackageName(), 0);
buildVersion = info.versionName; buildVersion = info.versionName;
} catch (NameNotFoundException e) { } catch (final NameNotFoundException e) {
Log.w(e); Log.w(e);
} }
IITC_AboutDialogPreference pref_about = (IITC_AboutDialogPreference) findPreference("pref_about"); final IITC_AboutDialogPreference pref_about = (IITC_AboutDialogPreference) findPreference("pref_about");
pref_about.setVersions(iitcVersion, buildVersion); pref_about.setVersions(iitcVersion, buildVersion);
final ListPreference pref_user_location_mode = (ListPreference) findPreference("pref_user_location_mode"); final ListPreference pref_user_location_mode = (ListPreference) findPreference("pref_user_location_mode");
pref_user_location_mode.setOnPreferenceChangeListener(new OnPreferenceChangeListener() { pref_user_location_mode.setOnPreferenceChangeListener(new OnPreferenceChangeListener() {
@Override @Override
public boolean onPreferenceChange(Preference preference, Object newValue) { public boolean onPreferenceChange(final Preference preference, final Object newValue) {
int mode = Integer.parseInt((String) newValue); final int mode = Integer.parseInt((String) newValue);
preference.setSummary(getResources().getStringArray(R.array.pref_user_location_titles)[mode]); preference.setSummary(getResources().getStringArray(R.array.pref_user_location_titles)[mode]);
return true; return true;
} }
}); });
String value = getPreferenceManager().getSharedPreferences().getString("pref_user_location_mode", "0"); final String value = getPreferenceManager().getSharedPreferences().getString("pref_user_location_mode", "0");
int mode = Integer.parseInt(value); final int mode = Integer.parseInt(value);
pref_user_location_mode.setSummary(getResources().getStringArray(R.array.pref_user_location_titles)[mode]); pref_user_location_mode.setSummary(getResources().getStringArray(R.array.pref_user_location_titles)[mode]);
} }
@ -64,7 +63,7 @@ public class MainSettings extends PreferenceFragment {
// so we need some additional hacks... // so we need some additional hacks...
// thx to http://stackoverflow.com/a/16800527/2638486 !! // thx to http://stackoverflow.com/a/16800527/2638486 !!
@Override @Override
public boolean onPreferenceTreeClick(PreferenceScreen preferenceScreen, Preference preference) { public boolean onPreferenceTreeClick(final PreferenceScreen preferenceScreen, final Preference preference) {
if (preference.getTitle().toString().equals(getString(R.string.pref_advanced_options)) if (preference.getTitle().toString().equals(getString(R.string.pref_advanced_options))
|| preference.getTitle().toString().equals(getString(R.string.pref_about_title))) { || preference.getTitle().toString().equals(getString(R.string.pref_about_title))) {
initializeActionBar((PreferenceScreen) preference); initializeActionBar((PreferenceScreen) preference);
@ -76,27 +75,27 @@ public class MainSettings extends PreferenceFragment {
// because PreferenceScreens are dialogs which swallow // because PreferenceScreens are dialogs which swallow
// events instead of passing to the activity // events instead of passing to the activity
// Related Issue: https://code.google.com/p/android/issues/detail?id=4611 // Related Issue: https://code.google.com/p/android/issues/detail?id=4611
public static void initializeActionBar(PreferenceScreen preferenceScreen) { public static void initializeActionBar(final PreferenceScreen preferenceScreen) {
final Dialog dialog = preferenceScreen.getDialog(); final Dialog dialog = preferenceScreen.getDialog();
if (dialog != null) { if (dialog != null) {
if (dialog.getActionBar() != null) dialog.getActionBar().setDisplayHomeAsUpEnabled(true); if (dialog.getActionBar() != null) dialog.getActionBar().setDisplayHomeAsUpEnabled(true);
View homeBtn = dialog.findViewById(android.R.id.home); final View homeBtn = dialog.findViewById(android.R.id.home);
if (homeBtn != null) { if (homeBtn != null) {
View.OnClickListener dismissDialogClickListener = new View.OnClickListener() { final View.OnClickListener dismissDialogClickListener = new View.OnClickListener() {
@Override @Override
public void onClick(View v) { public void onClick(final View v) {
dialog.dismiss(); dialog.dismiss();
} }
}; };
ViewParent homeBtnContainer = homeBtn.getParent(); final ViewParent homeBtnContainer = homeBtn.getParent();
// The home button is an ImageView inside a FrameLayout // The home button is an ImageView inside a FrameLayout
if (homeBtnContainer instanceof FrameLayout) { if (homeBtnContainer instanceof FrameLayout) {
ViewGroup containerParent = (ViewGroup) homeBtnContainer.getParent(); final ViewGroup containerParent = (ViewGroup) homeBtnContainer.getParent();
if (containerParent instanceof LinearLayout) { if (containerParent instanceof LinearLayout) {
// This view also contains the title text, set the whole view as clickable // This view also contains the title text, set the whole view as clickable